Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1 of 2] Fix & re-enable perf profiler test: update Java test program to better match test expectations. #904

Merged
merged 9 commits into from
Feb 27, 2023
Merged

[1 of 2] Fix & re-enable perf profiler test: update Java test program to better match test expectations. #904

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
639aeaf
Improvements to perf profiler Java test program.
Feb 22, 2023
a82c1b5
Better comments.
Feb 22, 2023
753735f
Fix graal aot.
Feb 22, 2023
c06cf4a
Lint.
Feb 22, 2023
50312fc
Align other profiler test cases to new Java test program.
Feb 22, 2023
13d6f6e
Align other profiler test cases to new Java test program.
Feb 22, 2023
cf686da
Fix stirling error test case.
Feb 23, 2023
5d978c1
Better test program with better comment.
Feb 23, 2023
e32e8de
Remove file that crept in.
Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Align other profiler test cases to new Java test program. 
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
  • Loading branch information
Pete Stevenson committed Feb 22, 2023
commit 13d6f6e8580329c4c0c44383fac152d28fb424b2
2 changes: 1 addition & 1 deletion src/stirling/source_connectors/perf_profiler/symbolizers/symbolizer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ TEST_F(BCCSymbolizerTest, DisableJavaSymbols) {
JavaSymbolizer::Create(std::move(symbolizer_)));

const std::filesystem::path java_app_path =
BazelRunfilePath("src/stirling/source_connectors/perf_profiler/testing/java/fib");
BazelRunfilePath("src/stirling/source_connectors/perf_profiler/testing/java/profiler_test");
ASSERT_TRUE(fs::Exists(java_app_path)) << java_app_path.string();
ASSERT_TRUE(fs::Exists(FLAGS_stirling_profiler_px_jattach_path))
<< FLAGS_stirling_profiler_px_jattach_path;
Expand Down