Allow timeout to be specified in OTel endpoint config #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
JamesMBartlett
approved these changes
Feb 17, 2023
| @@ -137,6 +137,8 @@ message OTelEndpointConfig { | |||
| map<string, string> headers = 2; | |||
| // True if the OpenTelemetry collector is not protected with SSL. | |||
| bool insecure = 3; | |||
| // The out of time in seconds before the request to the OTel collector should timeout. | |||
There was a problem hiding this comment.
nit: amount
also should probably mention the default timeout here.
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Mar 23, 2023
Summary: pixie-io#889 adds a timeout to the OTel collector request. This PR allows the user to specify the timeout, which is propagated to the plan node. Once this PR is merged, pixie-io#889 can be updated to use the timeout from the plan node, and if none is specified, uses a default. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Updated unit tests --------- Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: #889 adds a timeout to the OTel collector request. This PR allows the user to specify the timeout, which is propagated to the plan node. Once this PR is merged, #889 can be updated to use the timeout from the plan node, and if none is specified, uses a default.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Updated unit tests