Template PodDisruptionBudget apiVersion to enable support for older K8s versions #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
vihangm
approved these changes
Feb 14, 2023
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Feb 15, 2023
…8s versions (pixie-io#861) Summary: We have been seeing errors from several clusters where their deploy has failed due to being on an earlier K8s version without policy/v1 PodDisruptionBudgets. The API version change for pdb is currently the only item preventing us from supporting older K8s versions. This PR templatizes the etcd YAMLs so that we can choose between policy/v1 and policy/v1beta1 for PodDisruptionBudgets based on the K8s version. Currently, without the flag being set it selects `policy/v1` which is status quo. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Create and deploy Vizier rc with etcd option enabled Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We have been seeing errors from several clusters where their deploy has failed due to being on an earlier K8s version without policy/v1 PodDisruptionBudgets. The API version change for pdb is currently the only item preventing us from supporting older K8s versions.
This PR templatizes the etcd YAMLs so that we can choose between policy/v1 and policy/v1beta1 for PodDisruptionBudgets based on the K8s version. Currently, without the flag being set it selects
policy/v1which is status quo.Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Create and deploy Vizier rc with etcd option enabled