Fix config=aarch64_sysroot build #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihangm
approved these changes
Feb 13, 2023
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
fix_aarch64_build
branch
from
32fb8ff to
27c5db4
Compare
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Feb 15, 2023
Summary: To get aarch64 images to work I added a select on cpu:x86_64 for the java agent. I put this select in the wrong place, because it causes test builds to fail. This PR moves the select to where its only used for the image and not for the tests. Type of change: /kind cleanup Test Plan: Ran `bazel test --config=aarch64_sysroot //...` and saw only 7 failed tests as expected. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To get aarch64 images to work I added a select on cpu:x86_64 for the java agent. I put this select in the wrong place, because it causes test builds to fail.
This PR moves the select to where its only used for the image and not for the tests.
Type of change: /kind cleanup
Test Plan: Ran
bazel test --config=aarch64_sysroot //...and saw only 7 failed tests as expected.