Update obj_tools tests to not run on go1.16 #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihangm
force-pushed
the
clean_1_16-3
branch
from
4d8a194 to
ca7935f
Compare
aimichelle
approved these changes
Feb 10, 2023
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
vihangm
force-pushed
the
clean_1_16-3
branch
from
ca7935f to
c721c10
Compare
ddelnano
approved these changes
Feb 13, 2023
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Feb 15, 2023
Summary: Updates the obj_tools test to use go1.19 binaries instead of go1.16 binaries. Also updates the assertions accordingly. Relevant Issues: pixie-io#846 Type of change: /kind cleanup Test Plan: Ran the tests locally. Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates the obj_tools test to use go1.19 binaries instead
of go1.16 binaries. Also updates the assertions accordingly.
Relevant Issues: #846
Type of change: /kind cleanup
Test Plan: Ran the tests locally.