Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stat Chart (#787) #789

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Add Stat Chart (#787) #789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0422550
[GH-787] Add Stat Chart
NickLanam Feb 6, 2023
b65887d
Lint
NickLanam Feb 6, 2023
dd49f50
Add comments to all new proto fields; remove extraneous changes
NickLanam Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comments to all new proto fields; remove extraneous changes 
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
  • Loading branch information
@NickLanam
NickLanam committed Feb 9, 2023
commit dd49f5067a0239f2f0facb07ade22ae116406ff6
5 changes: 4 additions & 1 deletion src/api/proto/vispb/vis.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,11 +311,14 @@ message TimeseriesChart {
// StatChart The visual spec for a basic stat chart. Shows the latest value in the table as a big
// number with units.
message StatChart {
// Stat defines what information to show
message Stat {
// The (numeric) data field that will be used as the Y axis
// value is the ID of the column to use. The column should hold numeric data of some kind.
string value = 1;
NickLanam marked this conversation as resolved.
Show resolved Hide resolved
}
// stat is the definition of the stat chart
Stat stat = 1;
NickLanam marked this conversation as resolved.
Show resolved Hide resolved
// title of the chart, shown as a label for the data
string title = 2;
}

Expand Down
6 changes: 3 additions & 3 deletions src/pxl_scripts/watch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ cleanup() {
kill "${SERVER_PID}"
fi
emph "Cleanup"
echo "Run ${tty_green}localStorage.clear('px-custom-bundle-paths')${tty_reset}"
echo "Run ${tty_green}localStorage.clear('px-custom-bundle-path')${tty_reset}"
}

python3 cors_http_server.py &
Expand All @@ -62,8 +62,8 @@ trap 'cleanup' EXIT

emph "Running dev server for pxl_scripts"
echo "Open chrome console and add: "\
"${tty_green}localStorage.setItem('px-custom-bundle-paths',"\
"'["'"'"http://127.0.0.1:8000/bundle-oss.json"'"'"]')${tty_reset}"
"${tty_green}localStorage.setItem('px-custom-oss-bundle-path',"\
"'http://127.0.0.1:8000/bundle-oss.json')${tty_reset}"

while sleep 1; do
make -s bundle-oss.json
Expand Down