Increase ASAN short test timeout to address flaky tests#2294
Merged
ddelnano merged 3 commits intopixie-io:mainfrom Dec 12, 2025
Merged
Increase ASAN short test timeout to address flaky tests#2294ddelnano merged 3 commits intopixie-io:mainfrom
ddelnano merged 3 commits intopixie-io:mainfrom
Conversation
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
… test increases Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Increase ASAN short test timeout to address flaky tests
The following tests are frequently hitting the 2-minute Bazel timeout on ASAN builds:
//src/vizier/services/agent/shared/manager:heartbeat_test//src/vizier/services/agent/shared/manager:registration_test//src/carnot/builtins:collections_testBuildBuddy history from the main branch shows these tests are running up against the timeout threshold (see screenshot below). I believe BuildBuddy is under reporting the issues seen since builds are also seeing BEP API timeouts.
This PR increases the short test timeout to unblock ongoing Bazel 7 upgrade work and prevent unrelated PRs from failing due to these timeouts.
Relevant Issues: #2295
Type of change: /kind bugfix
Test Plan: Build succeeds