Allow configuring all ConnTrackers' debug trace level at runtime #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
oazizi000
approved these changes
Sep 16, 2024
ddelnano
deleted the
ddelnano/support-runtime-global-conn-tracker-debug-trace-level
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…ie-io#2023) Summary: Allow configuring all ConnTrackers' debug trace level at runtime When debugging tracing issues with servers that handle requests pre-fork, it's not practical to use `--stirling_conn_trace_pid` (each request is served by a new PID). This change allows enabling debug tracing for all conn trackers to facilitate easier debugging. Relevant Issues: N/A Type of change: /kind feature Test Plan: Skaffolded this change and verified that the following `stirling_ctrl` command enables `CONN_TRACE` globally. ``` $ ./stirling_ctrl ${pid_of_pem} 1 2 ``` Changelog Message: Provide mechanism for debugging a PEM's connection tracking more easily at runtime Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 2704ade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allow configuring all ConnTrackers' debug trace level at runtime
When debugging tracing issues with servers that handle requests pre-fork, it's not practical to use
--stirling_conn_trace_pid(each request is served by a new PID). This change allows enabling debug tracing for all conn trackers to facilitate easier debugging.Relevant Issues: N/A
Type of change: /kind feature
Test Plan: Skaffolded this change and verified that the following
stirling_ctrlcommand enablesCONN_TRACEglobally.Changelog Message: Provide mechanism for debugging a PEM's connection tracking more easily at runtime