-
Notifications
You must be signed in to change notification settings - Fork 487
[Add Local Addr & Port 2/3] Add columns to socket tracer #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We've historically relied on only capturing the remote addr, and using the PID along with K8s metadata to determine the local IP, but I do see value in capturing the local IP directly. So this looks good, except that this can't be landed in isolation. Will be looking at the follow-up PRs soon. |
JamesMBartlett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will lead to empty strings in the relevant tables, but as long as we don't release before the other diffs in this series land I think its ok.
|
Will hold off on landing until I have more confidence the other diffs will land. |
The other way to deal with this is to order things differently. It should be safe to do the data collection in bpf without actually pushing to the tables. And then have this diff come after that. Might require a bit of reshuffling, but logically that's how I would go about it (start from BPF code and layer diffs all the way up to pushing into the tables). |
|
Thanks for the feedback @oazizi000 @JamesMBartlett |
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
Summary: Adds data columns for local IP address and port to the socket tracer, which are populated by #1808 and #1809. This will support standalone pem entity relationships.
Type of change: /kind feature
Test Plan: Existing targets