Skip to content

Conversation

@benkilimnik
Copy link
Member

@benkilimnik benkilimnik commented Dec 21, 2023

Summary: Adds data columns for local IP address and port to the socket tracer, which are populated by #1808 and #1809. This will support standalone pem entity relationships.

Type of change: /kind feature

Test Plan: Existing targets

@benkilimnik benkilimnik requested a review from a team December 21, 2023 21:33
@benkilimnik benkilimnik marked this pull request as ready for review December 21, 2023 21:56
@oazizi000
Copy link
Contributor

We've historically relied on only capturing the remote addr, and using the PID along with K8s metadata to determine the local IP, but I do see value in capturing the local IP directly. So this looks good, except that this can't be landed in isolation. Will be looking at the follow-up PRs soon.

Copy link
Member

@JamesMBartlett JamesMBartlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will lead to empty strings in the relevant tables, but as long as we don't release before the other diffs in this series land I think its ok.

@JamesMBartlett
Copy link
Member

Will hold off on landing until I have more confidence the other diffs will land.

@oazizi000
Copy link
Contributor

I think this will lead to empty strings in the relevant tables, but as long as we don't release before the other diffs in this series land I think its ok.

The other way to deal with this is to order things differently. It should be safe to do the data collection in bpf without actually pushing to the tables. And then have this diff come after that. Might require a bit of reshuffling, but logically that's how I would go about it (start from BPF code and layer diffs all the way up to pushing into the tables).

@benkilimnik benkilimnik changed the title [Add Local Addr & Port 1/3] Add columns to socket tracer [Add Local Addr & Port 3/3] Add columns to socket tracer Jan 18, 2024
@benkilimnik
Copy link
Member Author

Thanks for the feedback @oazizi000 @JamesMBartlett
I've reordered the PRs such that data collection in bpf comes first #1808

@benkilimnik benkilimnik changed the title [Add Local Addr & Port 3/3] Add columns to socket tracer [Add Local Addr & Port 2/3] Add columns to socket tracer Jan 18, 2024
@benkilimnik benkilimnik requested a review from a team as a code owner January 24, 2024 18:08
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants