Add the px-mongo demo to the CLI #1802
Conversation
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
|
One minor comment otherwise this lgtm! |
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
demos/README.md
Outdated
| @@ -90,6 +90,20 @@ file describes the demo scenarios. | |||
|
|
|||
| 6. Replace all occurrences of the k8ssandra-operator namespace. At the time of this writing, the areas to search and replace include the namespace field for a given resource in addition to the cert-manager annotations (cert-manager.io/inject-ca-from). Note: there may be kustomize variables used for the cert-manager.io/inject-ca-from annotation, so ensure all usages reference the px-k8ssandra namespace. | |||
|
|
|||
| ## Updating the `px-mongo` demo | |||
|
|
|||
| 1. Clone `https://github.com/kpattaswamy/mern-k8s` | |||
There was a problem hiding this comment.
We probably don't want to link to a personal Github repo. We should probably pull this into one of Pixie's repos.
What sorts of changes are on this fork?
There was a problem hiding this comment.
The upstream demo app was done by the MongoDB team and relied on the demo's backend interacting with their hosted MongoDB atlas instance.
My fork made changes to that demo to create a local MongoDB instance and let the backend service interact with that instead of MongoDB's hosted one. It also contains the necessary docker compose/kubernetes manifests to run the demo locally and utilizes locust for constant load on the various backend endpoints.
There was a problem hiding this comment.
Agree with @aimichelle. We shouldn't linked to personal forks. If we need a fork, it should be under the pixie-io org. Happy to create the fork for you, just send me the info about where its forked from.
There was a problem hiding this comment.
Seems like the fork has been created and upstream added a license. Is there anything else to do here?
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
|
I was able to deploy the @aimichelle @JamesMBartlett is there anything else you want to see addressed? |
demos/README.md
Outdated
| @@ -90,6 +90,20 @@ file describes the demo scenarios. | |||
|
|
|||
| 6. Replace all occurrences of the k8ssandra-operator namespace. At the time of this writing, the areas to search and replace include the namespace field for a given resource in addition to the cert-manager annotations (cert-manager.io/inject-ca-from). Note: there may be kustomize variables used for the cert-manager.io/inject-ca-from annotation, so ensure all usages reference the px-k8ssandra namespace. | |||
|
|
|||
| ## Updating the `px-mongo` demo | |||
|
|
|||
| 1. Clone `https://github.com/kpattaswamy/mern-k8s` | |||
There was a problem hiding this comment.
Seems like the fork has been created and upstream added a license. Is there anything else to do here?
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Summary: This PR adds a demo app to test the mongo protocol tracing feature.
Related issues: Closes #640
Type of change: /kind feature
Test Plan: Uploaded the
px-mongodemo artifact to the GCS dev bucket. Tested the CLI and then deployed the demo to my cluster. Skaffolded Pixie with the latest mongo tracing changes and used the scratch pad to execute the mongo pxl script to verify data is being collected from the demo.Changelog Message: