Update AMQP's code generation README #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
ddelnano
approved these changes
Sep 12, 2023
etep
approved these changes
Sep 12, 2023
vihangm
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The steps to run AMQP's code generation involve running the python files with
bazeland notpython3. I experienced the confusion in the readme when I was following the steps to produce AMQP's protocol parsing code when testing out theExtractBEIntfunctionality in #1698.Related issues: N/A
Type of change: /kind cleanup
Test Plan: N/A