Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptiongroup to Privy requirements #1643

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

benkilimnik
Copy link
Member

@benkilimnik benkilimnik commented Aug 1, 2023

Summary: Fixes the privy build which was missing a dependency

Relevant Issues: Fixes #1642

Type of change: /kind cleanup

Test Plan: bazel build and tests inside privy work. Datagen works.

@benkilimnik benkilimnik temporarily deployed to pr-actions-approval August 1, 2023 22:43 — with GitHub Actions Inactive
Copy link
Member

@vihangm vihangm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and builds for me after this change. Just a small change requested.

src/datagen/pii/privy/requirements.in Outdated Show resolved Hide resolved
@vihangm vihangm changed the title Add exceptiongroup to Privy requirements (#1642) Add exceptiongroup to Privy requirements Aug 1, 2023
…l.txt

Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
@vihangm vihangm temporarily deployed to pr-actions-approval August 1, 2023 22:56 — with GitHub Actions Inactive
@vihangm vihangm merged commit edd3129 into pixie-io:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency in Privy, exceptiongroup
2 participants