Refactor probe specs (struct definitions) into their own sub-tree. #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) record & replay can depend on them. Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
ddelnano
approved these changes
Jul 20, 2023
vihangm
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In anticipation of merging the record & replay feature, we move the probe specs out from
bcc_wrapper.hinto a new fileprobe_specs.hin its own sub-tree. This enables other parts of our source code to include these struct definitions without depending on the BCC wrapper itself.Relevant Issues: #1163
Type of change: /kind feature
Test Plan: Existing tests.