Fix inline bash command #1598
Merged
Fix inline bash command #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentATo
had a problem deploying
to
pr-actions-approval
GitHub Actions
Error
FlorentATo
had a problem deploying
to
pr-actions-approval
GitHub Actions
Error
FlorentATo
force-pushed
the
fix_issue_1596
branch
from
ba80b08 to
c19716f
Compare
FlorentATo
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
|
Note: I don't really see the value of running bash is debug here. |
FlorentATo
force-pushed
the
fix_issue_1596
branch
from
c19716f to
0705732
Compare
FlorentATo
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
JamesMBartlett
approved these changes
Jul 10, 2023
|
Hi @FlorentATo. Thanks for your contribution. Could you please GPG sign your commit (see the guide if you need help: https://github.com/pixie-io/pixie/blob/main/CONTRIBUTING.md#sign-your-commits) |
FlorentATo
force-pushed
the
fix_issue_1596
branch
from
0705732 to
e60399e
Compare
FlorentATo
had a problem deploying
to
pr-actions-approval
GitHub Actions
Error
FlorentATo
had a problem deploying
to
pr-actions-approval
GitHub Actions
Error
|
Done @JamesMBartlett 👍 |
FlorentATo
force-pushed
the
fix_issue_1596
branch
from
52ad0aa to
e60399e
Compare
FlorentATo
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
|
Sorry @FlorentATo, we also need the commit to be GPG signed, see the sub point at the bottom of the section I sent: https://github.com/pixie-io/pixie/blob/main/CONTRIBUTING.md#commit-signature-verification |
Signed-off-by: Florent Tatard <ftatard@addenergie.com>
FlorentATo
force-pushed
the
fix_issue_1596
branch
from
e60399e to
6cb2b20
Compare
FlorentATo
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
|
Done @JamesMBartlett (sorry it took so long!) |
etep
pushed a commit
to etep/pixie
that referenced
this pull request
Jul 25, 2023
Summary: Fixed inline bash command for initContainer. Relevant Issues: pixie-io#1596 Type of change: /kind bug Test Plan: None Signed-off-by: Florent Tatard <ftatard@addenergie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixed inline bash command for initContainer.
Relevant Issues: #1596
Type of change: /kind bug
Test Plan: None