Implement Go's varint 64 bit integer decoding in binary decoder #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
|
@pixie-io/maintainers with Pete out this week, could you give this the first review pass? |
vihangm
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Seems to line up with the go impl at https://github.com/golang/go/blob/master/src/encoding/binary/varint.go#L62-L88
Do you want to consider adding some more edge case tests like https://github.com/golang/go/blob/master/src/encoding/binary/varint_test.go#L163-L180 ?
…an an error Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
vihangm
approved these changes
Jun 28, 2023
etep
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Implement Go's varint 64 bit integer decoding in binary decoder
Our go version detection has been the source of a few bugs (#1300, #1318). This has highlighted that our go version detection is very different than how the
go versioncli works. In order to align our version detection with the go cli, we need to be able to decode these varints since parts of Go's buildinfo header use this encoding (source).Relevant Issues: #1318 #1300
Type of change: /kind feature
Test Plan: Used the following go program to draft the new test cases