Use service-tls CA in operator when monitoring vizier #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
aimichelle
approved these changes
Jun 13, 2023
aimichelle
pushed a commit
that referenced
this pull request
Jun 14, 2023
Summary: Using the pod advertised DNS addr instead of the IP address ensures that the SSL cert is valid and that we can scrape with TLS. Relevant Issues: Followup to a breakage caused by #1480 Type of change: /kind bug Test Plan: skaffold the operator to test. --------- Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This switches to using the CA from the cluster certs
when monitoring vizier instead of skipping TLS Verify.
Type of change: /kind cleanup
Test Plan: skaffolded an operator and verified that it got the
CA and used it.
Changelog Message: