Skip to content

Conversation

@NickLanam
Copy link
Member

@NickLanam NickLanam commented May 31, 2023

Summary: Does the following:

  • Updates esbuild and Webpack to versions that support TypeScript 5.x.
  • Re-runs yarn dlx @yarnpkg/sdks so that VS Code can still resolve dependencies normally.
  • Bumps required Node version to LTS 18.16.0, to fix Jest hanging.

Type of change: /kind cleanup

Test Plan: Run yarn lint, yarn test, yarn run build_prod, and yarn dev. All should still function normally, though a hair faster.

@NickLanam NickLanam requested review from aimichelle and vihangm May 31, 2023 00:00
@NickLanam
Copy link
Member Author

Note: dependency license check is flagging dependencies that we already use and simply updated.

Copy link
Member

@vihangm vihangm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot happening in this PR, can we split it into 3 separate PRs?

  • Fix lint issues
  • Upgrade yarn
  • Finally upgrade all our npm deps

NickLanam added 3 commits May 31, 2023 13:05
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
@NickLanam
Copy link
Member Author

There's a lot happening in this PR, can we split it into 3 separate PRs?

* Fix lint issues

* Upgrade yarn

* Finally upgrade all our npm deps

Done, this PR now only does the final dep update and the tooling update (those have to happen at the same time, updating TypeScript breaks the tooling but the tooling won't update without the new version of TypeScript).

@NickLanam NickLanam requested a review from vihangm May 31, 2023 20:13
@vihangm vihangm merged commit eebedc2 into pixie-io:main May 31, 2023
@NickLanam NickLanam deleted the typescript-5 branch May 31, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants