[qemu] Use ssh to run tests inside of qemu machine #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMBartlett
force-pushed
the
qemu_use_ssh
branch
4 times, most recently
from
4d88ef5 to
77eeb6e
Compare
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
qemu_use_ssh
branch
from
77eeb6e to
d31ba8c
Compare
vihangm
approved these changes
May 8, 2023
zasgar
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: QEMU tests now start a qemu instance in the background and then SSH into the machine to run tests. This makes the logs much cleaner and also enables running interactively in a normal terminal instead of a serial console.
Type of change: /kind test-infra
Test Plan: Tested that
bazel test --config=qemu-bpf //...works (apart from a flake in stirling error bpf test that I'll address separately).