[actions] Use buildbuddy only on self-hosted runners #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
github_bazelrc
branch
from
7b7c006 to
9ec1ee5
Compare
JamesMBartlett
changed the title
|
@pixie-io-buildbot test this please |
aimichelle
approved these changes
Mar 29, 2023
ddelnano
pushed a commit
to ddelnano/pixie
that referenced
this pull request
May 1, 2023
Summary: We don't want to use buildbuddy from github actions directly because of potential egress/ingress costs from github actions to gcloud. Instead once pixie-io#1108 lands, self-hosted runners will have access to buildbuddy. This PR replaces adding the buildbuddy api key with adding github specific bazelrc options. Type of change: /kind test-infra Test Plan: Tested that these configs work in pixie-io#1054 Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We don't want to use buildbuddy from github actions directly because of potential egress/ingress costs from github actions to gcloud. Instead once #1108 lands, self-hosted runners will have access to buildbuddy. This PR replaces adding the buildbuddy api key with adding github specific bazelrc options.
Type of change: /kind test-infra
Test Plan: Tested that these configs work in #1054