[dev_dns_updater] Fix dev_dns_updater for use with the new GKE auth plugin #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimichelle
approved these changes
Mar 24, 2023
…lugin Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
dev_dns_fix
branch
from
54e54e9 to
939b3d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The
dev_dns_updaterused to rely on running entirely undersudo. This broke k8s auth with the new GKE auth plugin. Instead we only usesudoto update the/etc/hostsfile, and run the rest under the user.Type of change: /kind bug
Test Plan: Tested that the
dev_dns_updaternow works with the new GKE auth plugin.