Refactor the qemu kernel selector logic #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zain Asgar <zasgar@pixielabs.ai>
vihangm
approved these changes
Mar 15, 2023
bazel/pl_qemu_kernels.bzl
Outdated
| for version, sha in kernel_catalog.items(): | ||
| http_file( | ||
| name = kernel_version_to_name(version), | ||
| url = "https://storage.googleapis.com/pixie-dev-public/kernel-build/20230228151027/linux-build-{}.tar.gz".format(version), |
There was a problem hiding this comment.
you need to use kernel_build_date here instead of hardcoding the value
There was a problem hiding this comment.
should we also reuse kernel_version_to_name here?
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Mar 23, 2023
Summary: This cleans up the kernel import and selector logic to remove manual config and copy/paste. Relevant Issues: pixie-io#709 Type of change: /kind test-infra Test Plan: `bazel test -c opt --config=qemu-bpf --cache_test_results=no --remote_download_outputs=all //src/stirling/source_connectors/socket_tracer:redis_trace_bpf_test --test_output=streamed --//bazel/test_runners/qemu_with_kernel:kernel_version=latest` Signed-off-by: Zain Asgar <zasgar@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This cleans up the kernel import and selector logic to remove manual
config and copy/paste.
Relevant Issues: #709
Type of change: /kind test-infra
Test Plan:
bazel test -c opt --config=qemu-bpf --cache_test_results=no --remote_download_outputs=all //src/stirling/source_connectors/socket_tracer:redis_trace_bpf_test --test_output=streamed --//bazel/test_runners/qemu_with_kernel:kernel_version=latest