support kubeconfig options when using kubectl command #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@pixie-io-buildbot test this please |
|
Thanks for your contribution! |
|
@JamesMBartlett I've updated the commit message. |
|
@pixie-io-buildbot test this please |
|
@pixie-io-buildbot test this please |
JamesMBartlett
approved these changes
Mar 21, 2023
|
Can you please GPG sign your commit? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Summary: When deploy using `px --kubeconfig THE_KUBE_FILE deploy`, it failed with error `✕ Kubectl > 1.10.0 is present ERR: exit status 1`. And I found the px cli has the `--kubeconfig` option, but the internal kubectl command didn't respect it. Relevant Issues: N/A Type of change: /kind bug Test Plan: Run `px deploy` with `--kubeconfig` option should work without problem. Signed-off-by: Xudong Zhang <felixmelon@gmail.com>
I've signed the commit and rebased. |
|
@pixie-io-buildbot test this please |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support kubeconfig options when using kubectl command
Summary: When deploy using
px --kubeconfig THE_KUBE_FILE deploy,it failed with error
✕ Kubectl > 1.10.0 is present ERR: exit status 1.And I found the px cli has the
--kubeconfigoption, but the internalkubectl command didn't respect it.
Relevant Issues: N/A
Type of change: /kind bug
Test Plan: Run
px deploywith--kubeconfigoption should work withoutproblem.