Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User deletion and Organization selection #655

Open
sgewirtz1 opened this issue Nov 21, 2022 · 4 comments
Open

User deletion and Organization selection #655

sgewirtz1 opened this issue Nov 21, 2022 · 4 comments
Assignees
Labels
area/control-plane go Pull requests that update Go code good first issue Good for newcomers kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sgewirtz1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When I have a collection of resources that I'm managing and want to add users to my organization for those that sign up in a timely fashion with the invite link it works fine, but for users that sign up either directly or with the incorrect or an old link the system creates their user account with their own default organization and from then on it's impossible for them to delete their user account or to join a new/different organization.

Describe the solution you'd like
A clear and concise description of what you want to happen.

  1. A user administration capability to delete the user's account from the system so they can have a fresh start
  2. A user organization management selector so that users can be part of more than one organization

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
As an alternative to 2 providing the user the ability to either leave their organization to move to another or to delete the user's organization so they can join another
Additional context
Add any other context or screenshots about the feature request here.
Slack link: https://pixie-community.slack.com/archives/CQ63KEVFY/p1668936141076099
Question:
is there a way to add a user to my org if they've already logged in to their own org? alternatively can we somehow delete his org so he can join our org?

Answer:
currently there isn’t a way to switch a user’s org. The best way to handle this right now is to delete their Pixie account and have them sign up again. Can you have the user email me their account information and ask to have their account deleted and we can look at it on Monday?

@ghost ghost added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 21, 2022
@sgewirtz1
Copy link
Contributor Author

Depending on the scope and feedback I could attempt a PR for this

@htroisi
Copy link
Contributor

htroisi commented Nov 22, 2022

For this specific use case, I think the simplest solution would be to add the ability for a user to delete their own account.

According to @aimichelle, Pixie already has the capability to remove other users from your org. However, if you’re the last user in the org (i.e. you accidentally created your own org and you're the only person in it), we don’t allow you to. So the improvement here would be to implement the following: if you are the last user in the org, and you try to remove yourself, it will tell you that the org will also be deleted.

@sgewirtz1
Copy link
Contributor Author

sgewirtz1 commented Nov 22, 2022 via email

@VishwasSomasekhariah
Copy link

Any Updates on this? Or workaround for now, until the issue is addressed.

@htroisi htroisi added the good first issue Good for newcomers label Jan 3, 2023
@aimichelle aimichelle self-assigned this Jun 2, 2023
@aimichelle aimichelle added kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/control-plane go Pull requests that update Go code and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2023
aimichelle added a commit that referenced this issue Jun 6, 2023
Summary: We currently allow users to be deleted/removed from an org if
they are not the last user in the org. This PR adds the ability to
delete a user and the org if they are the last one in the org.
This is also useful for testing/automation.

Relevant Issues: #655

Type of change: /kind feature

Test Plan: unit tests

---------

Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
aimichelle added a commit that referenced this issue Jun 6, 2023
Summary: We are adding user deletion to the API. #1434 added user
deletion to the internal profile service. This PR adds it to the
external-facing gRPC API. A followup diff will later add it to gql.

Relevant Issues: #655

Type of change: /kind feature

Test Plan: unit tests

---------

Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
aimichelle added a commit that referenced this issue Jun 6, 2023
Summary: Previous changes added deleteUser to the profile and API gRPC
services. This PR adds it to the graphql layer.

Relevant Issues: #655

Type of change: /kind feature

Test Plan: Unit tests

Changelog Message:
```release-note
Add API to delete user in GQL and gRPC. If the user being deleted is the only user in the org, the org will also be deleted.
```

---------

Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane go Pull requests that update Go code good first issue Good for newcomers kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants