Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave and TwitchAdSolutions #276

Closed
ryanbr opened this issue Aug 20, 2024 · 3 comments
Closed

Brave and TwitchAdSolutions #276

ryanbr opened this issue Aug 20, 2024 · 3 comments

Comments

@ryanbr
Copy link

ryanbr commented Aug 20, 2024

TwitchAdSolutions scriplet vaft-ublock-origin is included in experimental currently, and used in Beta/Nightly users for some time

Seems to work well, just want to confirm it works well with you.

  • If we enabled the twitch adblock by default, would we expect any issues? or any possible downsides?
  • We have a private AdBlock list authors Slack for devs uBO/Adguard/ABP/Brave/Ghostery etc, if you want to join. Flick me an email address to mp3geek@gmail.com. If you're keen
@pixeltris
Copy link
Owner

If we enabled the twitch adblock by default, would we expect any issues? or any possible downsides?

If someone already has one of the scripts enabled as a userscript or if they have TTV LOL PRO enabled (https://github.com/younesaassila/ttv-lol-pro) it'll conflict and streams will fail to load (black screen with an infinite loading wheel)

I can't remember if I mentioned it but the VAFT script can be a little spammy. Worth checking the network tab of dev tools and filtering for m3u8 and seeing if the additional requests are acceptable

There can be playback issues #164 but I'm not sure how regular they are. The issues mostly occur on midroll ads

@ryanbr
Copy link
Author

ryanbr commented Aug 20, 2024

Could the scriptlet used detect bpaoeijjlplfjbagceilcgbkcdjbomjd installed and just silently exit?

@pixeltris
Copy link
Owner

pixeltris commented Aug 20, 2024

144bc99?diff=unified&w=1 adds the Worker check from AdGuard Extra which fixes the black screen / infinite loading wheel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants