Skip to content

V2.0.1 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

V2.0.1 #5

wants to merge 14 commits into from

Conversation

@KushalNParmar
Copy link

@KushalNParmar KushalNParmar commented Nov 10, 2025

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2025
View reviewed changes
app/src/main/java/io/pixelbin/glamar/sample/MyApp.kt
GlamArLogger.d("Glam_myApp", "onCreate: ")

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
WebView.setWebContentsDebuggingEnabled(true)

Check failure

Code scanning / CodeQL

Android Webview debugging enabled High

Webview debugging is enabled.

Copilot Autofix

AI 25 days ago

To fix the issue, we should ensure that WebView debugging is enabled only during debug builds. This is typically done by checking the ApplicationInfo.FLAG_DEBUGGABLE flag at runtime. In Kotlin, within an Application subclass, you can obtain this by evaluating the following condition:

if (0 != applicationInfo.flags and ApplicationInfo.FLAG_DEBUGGABLE)

We need to change the block (lines 16-18) to perform this conditional check instead of always enabling debugging. No additional imports are needed unless android.content.pm.ApplicationInfo is referenced by name, but in this case ApplicationInfo is accessible via android.app.Application. So only the specific lines need adjustment, and no extra methods or variable definitions are required.

Suggested changeset 1
app/src/main/java/io/pixelbin/glamar/sample/MyApp.kt

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/app/src/main/java/io/pixelbin/glamar/sample/MyApp.kt b/app/src/main/java/io/pixelbin/glamar/sample/MyApp.kt
--- a/app/src/main/java/io/pixelbin/glamar/sample/MyApp.kt
+++ b/app/src/main/java/io/pixelbin/glamar/sample/MyApp.kt
@@ -14,7 +14,9 @@
         GlamArLogger.d("Glam_myApp", "onCreate: ")
 
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
-            WebView.setWebContentsDebuggingEnabled(true)
+            if (0 != applicationInfo.flags and android.content.pm.ApplicationInfo.FLAG_DEBUGGABLE) {
+                WebView.setWebContentsDebuggingEnabled(true)
+            }
         }
 
         val webView = WebView(
EOF
@@ -14,7 +14,9 @@
GlamArLogger.d("Glam_myApp", "onCreate: ")

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
WebView.setWebContentsDebuggingEnabled(true)
if (0 != applicationInfo.flags and android.content.pm.ApplicationInfo.FLAG_DEBUGGABLE) {
WebView.setWebContentsDebuggingEnabled(true)
}
}

val webView = WebView(
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakesh-singh-parihar rakesh-singh-parihar Awaiting requested review from rakesh-singh-parihar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KushalNParmar @dipendra-sharma @gauthamprabhu8