Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add persistentkeepalive info #8

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

DerDanilo
Copy link

@coolapso coolapso changed the base branch from master to test June 8, 2021 08:09
@coolapso coolapso changed the base branch from test to master June 15, 2021 10:55
@coolapso
Copy link
Member

Crap I messed up here ... I am really sorry!

Can you please close this one and re-open another one with the updated master??

either that or Revert my "Not so conflict resolving commit" and properly fix the conflict

## Updatinging Wireguard

Should be

## Updating Wireguard

@DerDanilo
Copy link
Author

DerDanilo commented Jun 15, 2021

Happens. Just merge it and commit a change later on. Or the owner (you?) of the repo can do a commit into the master. Shouldn't be an issue for a docs repo.

@orazioedoardo
Copy link
Member

Happens. Just merge it and commit a change later on. Or the owner (you?) of the repo can do a commit into the master. Shouldn't be an issue for a docs repo.

You can just add more commits to your branch.

Keep Wireguard connected / Connection issues / PersistentKeepalive.

It's not actually related to connection issues. Yes it will speed up connections a bit since there is no on-demand handshake but, in the context of PiVPN, persistentkeepalive is only useful if the raspberrypi wants to connect to a client long after the client initiated session has expired due to nat.

You may update already existing profiles with pivpn -up ("Updates PiVPN Scripts").

This is not available anymore.

@DerDanilo
Copy link
Author

You may update already existing profiles with pivpn -up ("Updates PiVPN Scripts").

This is not available anymore.

I removed the line from the manual.
I think that it's necessary to be able to regenerate the profiles in case of config changes. Was there ever a function to do so?
Right now I'm handling this with Ansible which, or course, requires Ansible skills but would be nice if the script(s) itself would be able to handle this.

@orazioedoardo
Copy link
Member

I think that it's necessary to be able to regenerate the profiles in case of config changes. Was there ever a function to do so?

No, however this could be a feature of pivpn add: detect when the template (setupvars) has been changed and prompt for regeneration.

@coolapso
Copy link
Member

will merge this when test gets merged into master.

@coolapso coolapso merged commit 33ce2a2 into pivpn:master Aug 5, 2021
@coolapso
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants