Add explicit module definition to a multi-release jar #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivovarit
reviewed
Sep 25, 2024
|
Thanks, it looks good to me - let me double-check this, and if everything is fine, I'm releasing 1.6.1 |
pivovarit
changed the title
pivovarit
approved these changes
Sep 26, 2024
pivovarit
pushed a commit
that referenced
this pull request
Sep 26, 2024
This adds a module-info to the final jar under `META-INF/versions/9`. It will not affect compatibility with Java 8 This will enable downstream libraries (I'm looking at https://github.com/bbottema/simple-java-mail now) to have module infos of their own and for consumers to use `jlink`.
pivovarit
pushed a commit
that referenced
this pull request
Sep 26, 2024
This adds a module-info to the final jar under `META-INF/versions/9`. It will not affect compatibility with Java 8 This will enable downstream libraries (I'm looking at https://github.com/bbottema/simple-java-mail now) to have module infos of their own and for consumers to use `jlink`.
|
I have just released 1.6.1 with explicit module definition - let me know if that helps (give it some time to appear in Central, though) |
Works just fine. The whole "literally everything must be a module to use some tooling" thing is annoying, but sure does give me a task to do. |
|
To be honest, I'm surprised it's not working out of the box with automatic modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a module-info to the final jar under
META-INF/versions/9. It will not affect compatibility with Java 8This will enable downstream libraries (I'm looking at https://github.com/bbottema/simple-java-mail now) to have module infos of their own and for consumers to use
jlink.