Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel and Table and Paneltable padding #350

Closed
elliotdahl opened this issue Jan 7, 2016 · 4 comments
Closed

Panel and Table and Paneltable padding #350

elliotdahl opened this issue Jan 7, 2016 · 4 comments

Comments

@elliotdahl
Copy link

The padding on Panels is 15px all around and the padding for tables is 10px. When I make a Panel with a Table in it I have conflicting paddings between the Panel header and body. Is there an easier way to strip the padding from Panels and have it match the tables? Or can we make both of them adhere to the same internal padding and then customize from there for specific use cases?

screen shot 2016-01-07 at 9 38 17 am

@charleshansen
Copy link
Contributor

For what it is worth, the 15px on Panels is coming from Bootstrap, I'm personally fine overriding it. Table headers have 15px 10px padding, which we might want to change to 10px all around if we change Panels. Thoughts @pivotal-plech ?

@charleshansen
Copy link
Contributor

Also, for a more drastic solution, see #342

@pivotal-plech
Copy link
Contributor

I would rather have them "both of them adhere to the same internal padding and then customize from there for specific use cases".

I think by having to specify a padding for every container/panel would result in inconsistencies. We should have a reasonable default '15px', and the ability to override when necessary.

@charleshansen
Copy link
Contributor

The 15px paddings have been replaced with 10px paddings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants