Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container padding is a pain in the ass #342

Closed
atomanyih opened this issue Dec 16, 2015 · 2 comments
Closed

container padding is a pain in the ass #342

atomanyih opened this issue Dec 16, 2015 · 2 comments

Comments

@atomanyih
Copy link
Contributor

on many of the panels on appsman we use this class:

.reset-panel {
  .panel-header {
    padding: 0;
  }

  .panel-body {
    padding: 0;
  }

  .panel-title-alt {
    padding: $panel-title-padding;
  }
}

because it sucks that panels add padding to places you can't control easily.
I have a theory that this is the whole reason innerClassName and the padding prop is a thing.
If our containers didn't have their own padding, consumers could pass in components with whatever whitespace they wanted and not have to reset stuff through css

@atomanyih
Copy link
Contributor Author

@charleshansen
Copy link
Contributor

Seems too drastic for the moment. We are going to try having more unified padding in the components (it is currently sometimes 10px and sometimes 15px) so you don't have to override quite as often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants