Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Modals are not Node compatible #311

Closed
d-reinhold opened this issue Oct 27, 2015 · 0 comments
Closed

React Modals are not Node compatible #311

d-reinhold opened this issue Oct 27, 2015 · 0 comments

Comments

@d-reinhold
Copy link
Contributor

When requiring pui-react-modals in a node environment (i.e. server side rendering), the following error occurs:

/Users/pivotal/workspace/apps-manager-js/node_modules/pui-react-modals/node_modules/classlist-polyfill/src/index.js:18
11:39:26 web.1     |  if ("document" in window.self) {
11:39:26 web.1     |            ^
11:39:26 web.1     |  ReferenceError: window is not defined
11:39:26 web.1     |      at Object.<anonymous> (/Users/pivotal/workspace/apps-manager-js/node_modules/pui-react-modals/node_modules/classlist-polyfill/src…
11:39:26 web.1     |      at Module._compile (module.js:456:26)

Perhaps we could investigate using a better classlist polyfill, or write our own (or use the underlying DOM API directly).

atomanyih pushed a commit that referenced this issue Oct 27, 2015
now you can turn off animations too ;)

fixes #296 #311

[fixes #106334194]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants