feat (Dropdown) close dropdown when item is selected [Fixes #118443355]

Signed-off-by: Dan Dzoan <ddzoan@pivotal.io>
pivotal-cf · Apr 27, 2016 · ed3c6c5 · ed3c6c5
1 parent 431ac0d
commit ed3c6c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/library/spec/pivotal-ui-react/dropdown/dropdown_spec.js b/library/spec/pivotal-ui-react/dropdown/dropdown_spec.js
@@ -108,6 +108,13 @@ describe('Dropdowns', () => {
           expect('.open .dropdown-menu').not.toExist();
         });
 
+        it('hides when a menu item is selected', () => {
+          $('.dropdown-toggle').simulate('click');
+          expect('.open .dropdown-menu').toExist();
+          $('li:contains(Item #1)').simulate('click');
+          expect('.open .dropdown-menu').not.toExist();
+        });
+
         describe('when scrim is disabled', () => {
           it('does not hide the dropdown menu when clicking outside of the dropdown', () => {
             subject::setProps({disableScrim: true});

diff --git a/library/src/pivotal-ui-react/dropdowns/dropdowns.js b/library/src/pivotal-ui-react/dropdowns/dropdowns.js
@@ -71,7 +71,7 @@ class Dropdown extends mixin(React.Component).with(Scrim) {
       <div className={dropdownClasses}>
         {dropdownLabel}
         {dropdownToggle}
-        <ul className={dropdownMenuClasses}>{children}</ul>
+        <ul className={dropdownMenuClasses} onClick={this.scrimClick}>{children}</ul>
       </div>
     );
   };