Add type='button' to modal close button [#153031749]

Signed-off-by: Reid Mitchell <rmitchell@pivotal.io>
pivotal-cf · Nov 30, 2017 · b2acf7f · b2acf7f
1 parent aee8267
commit b2acf7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/spec/pivotal-ui-react/modals/modals_spec.js b/spec/pivotal-ui-react/modals/modals_spec.js
@@ -22,6 +22,11 @@ describe('Modals', () => {
 
       expect(findByClass(result, 'myModal')).toBeDefined();
     });
+
+    it('renders a close button of type button', () => {
+      result.open();
+      expect('.modal-close button.btn.btn-icon').toHaveAttr('type', 'button');
+    });
   });
 
   describe('#close', () => {

diff --git a/src/react/modals/modals.js b/src/react/modals/modals.js
@@ -149,7 +149,7 @@ export class BaseModal extends mixin(React.PureComponent).with(Animation) {
               <div className="modal-header">
                 <h3 className="modal-title em-high">{title}</h3>
                 <div className="modal-close">
-                  <button className="btn btn-icon" onClick={onHide}>
+                  <button className="btn btn-icon" onClick={onHide}  type="button">
                     <Icon src="close"/>
                   </button>
                 </div>