allow custom form layouts [#159317578]

Signed-off-by: Jonathan Berney <jberney@pivotal.io>
pivotal-cf · Jul 30, 2018 · 6c621a2 · 6c621a2
1 parent 07fed7d
commit 6c621a2
Show file tree

Hide file tree

Showing 10 changed files with 1,421 additions and 976 deletions.
diff --git a/spec/pivotal-ui-react/form/form-col_spec.js b/spec/pivotal-ui-react/form/form-col_spec.js
diff --git a/spec/pivotal-ui-react/form/form-row_spec.js b/spec/pivotal-ui-react/form/form-row_spec.js
@@ -23,42 +23,6 @@ describe('FormRow', () => {
     expect('#root > .grid .col:eq(1)').toHaveText('test');
   });
 
-  describe('when given form props', () => {
-    let formProps;
-
-    beforeEach(() => {
-      formProps = {
-        state: {key: 'value'},
-        setState: () => 'set state',
-        canSubmit: () => 'can submit',
-        onSubmit: () => 'on submit',
-        canReset: () => 'can reset',
-        reset: () => 'reset',
-        onChange: () => () => 'on change',
-        onBlur: () => 'on blur'
-      };
-
-      ReactDOM.render(<FormRow {...formProps}>
-        <FormCol id="col1">{field1}</FormCol>
-        <FormCol id="col2">{field2}</FormCol>
-      </FormRow>, root);
-    });
-
-    it('passes the props down to each child', () => {
-      expect(FormCol).toHaveBeenRenderedWithProps({
-        id: 'col1',
-        children: field1,
-        ...formProps
-      });
-
-      expect(FormCol).toHaveBeenRenderedWithProps({
-        id: 'col2',
-        children: field2,
-        ...formProps
-      });
-    });
-  });
-
   describe('when given a wrapper', () => {
     beforeEach(() => {
       subject::setProps({wrapper: () => <div className="wrapper"/>});
@@ -72,34 +36,6 @@ describe('FormRow', () => {
     });
   });
 
-  describe('when given invalid children', () => {
-    beforeEach(() => {
-      spyOn(console, 'warn');
-      class FakeFormCol extends FormCol {
-        render() {
-          return <div className="fake-col">fake col</div>;
-        }
-      }
-
-      ReactDOM.render(<FormRow>
-        <div className="invalid-element">Invalid element</div>
-        <FakeFormCol />
-      </FormRow>, root);
-    });
-
-    it('renders the fake form col', () => {
-      expect('.fake-col').toExist();
-    });
-
-    it('does not render the invalid-element', () => {
-      expect('.invalid-element').not.toExist();
-    });
-
-    it('shows a warning', () => {
-      expect(console.warn).toHaveBeenCalledWith('Child of type "div" will not be rendered. A FormRow\'s children should be of type FormCol.');
-    });
-  });
-
   describe('when given a class name and an ID', () => {
     beforeEach(() => {
       spyOnRender(Grid).and.callThrough();