Fix libcurl related memory leak #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling curl_global_init() and curl_global_cleanup() on every http_client_init() / http_client_exit() leads to memory leak (at least, if you use it with OpenSSL). The official documentation also says that curl_global_init() should only be called once: https://ec.haxx.se/libcurl/libcurl-globalinit So this patch changes the code to call the curl_global_init() and curl_global_cleanup() in the main() function only once. Signed-off-by: Martin Schiller <ms@dev.tdt.de>
|
thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling curl_global_init() and curl_global_cleanup() on every
http_client_init() / http_client_exit() leads to memory leak (at least,
if you use it with OpenSSL).
The official documentation also says that curl_global_init() should only
be called once:
https://ec.haxx.se/libcurl/libcurl-globalinit
So this patch changes the code to call the curl_global_init() and
curl_global_cleanup() in the main() function only once.
Signed-off-by: Martin Schiller ms@dev.tdt.de