Fix mypy
errors and rename NamedTuple
fields in gym.py
#199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #45 by fixing existing type hint errors prior to introducing
mypy
to the repo.Run
mypy
with--strict
flag and fix resultingmypy
errors ingym.py
.Rename some fields in the
Gym
NamedTuple
class in order to clarify their meanings and to fix amypy
error. Thecount
field specifically causes amypy
error becausemypy
interprets the field's name as thecount
method thatNamedTuple
inherits from the basetuple
class: According to themypy
devs, this is expected behavior and is not a bug:Before:
After:
Like the remaining
mypy
errors from #193, we'll need to ignore thesemissing-imports
errors with--ignore-missing-imports
.