-
Couldn't load subscription status.
- Fork 0
Refine the code structure for percentile rank #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the code structure for percentile rank #13
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, thank you. Can you just address the two comments I posted?
|
Or I can just do so myself, actually. |
|
Thank you. Let me do this right away. |
|
Comments addressed. @pitrou |
This refinement is based on facts that:
NullPartitionResultgenerated by "sort and mark duplicate";Therefore we can decouple these two operations from the current
Ranker, and only combine them in the concreteRankXXXMetaFunctions, which themselves can be CRTP-ed.This refinement: