-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import deprecated scipy.linalg.triu from numpy.triu instead #3524
Conversation
Removing Import of depecrated triu function imported from scipy lib
Done updated the PR |
@mpenkov this fix seems important. Another maintenance release of Gensim may be timely anyway – drop unsupported Python versions, add new Python versions, etc. WDYT? How about a release session, one of these days? |
Sure, we need to work out what's going on with the Windows builds, first. That's been on my todo list for a while. |
The failing Windows builds seem to be caused by pypa/cibuildwheel#1740. |
Thank you for pointing that out @unlimitedsola |
python3Packages.scipy update to 1.13.0 removed triu. Patch from upstream commit replaces it with numpy.triu if import from scipy.linalg.triu fails. piskvorky/gensim#3524 scipy/scipy#19674
Pinning scipy to version lower than 1.13 to avoid the following error: ImportError: cannot import name 'triu' from 'scipy.linalg' (/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/scipy/linalg/__init__.py) This version restriction can be removed when packages that depend on triu are fixed. See e.g.: - piskvorky/gensim#3524 - scipy/scipy#20402
Pinning scipy to version lower than 1.13 to avoid the following error: ImportError: cannot import name 'triu' from 'scipy.linalg' (/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/scipy/linalg/__init__.py) This version restriction can be removed when packages that depend on triu are fixed. See e.g.: - piskvorky/gensim#3524 - scipy/scipy#20402
I'd like to express interest in a new release with this fix :) |
Pinning scipy to version lower than 1.13 to avoid the following error: ImportError: cannot import name 'triu' from 'scipy.linalg' (/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/scipy/linalg/__init__.py) This version restriction can be removed when packages that depend on triu are fixed. See e.g.: - piskvorky/gensim#3524 - scipy/scipy#20402
why is the 4.3.3 release missing from the github release page? |
The scipy package latest released has removed the triu function due to its support already provided in numpy package
Diff from the scipy library :
scipy/scipy@5721702#diff-6482beada610f60c724811cf77561f2bde8fd44ed2349939e505d28746a6d078
Removing the triu import from scipy library and getting it instead from numpy
Fixes #3525.