-
-
Notifications
You must be signed in to change notification settings - Fork 71
Update documentation #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 92.46% 93.23% +0.76%
==========================================
Files 91 92 +1
Lines 4939 4998 +59
==========================================
+ Hits 4567 4660 +93
+ Misses 372 338 -34
Continue to review full report at Codecov.
|
The diagram can be found here (as it won't appear in source or on github preview): https://github.com/pisa-engine/pisa/blob/docs-update/docs/source/_static/img/pipeline.png I'm not sure if I'm making those inter-links properly, but I think so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the links work, this looks great. Nice diagram btw :-)
@amallia can we verify the links before merging? E.g., can I build it locally? |
I think we shoudl rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just a small comment
I added an issue for changing the name of wand data: #442 at this point let's leave it what it is in the diagram and docs, I don't want to create confusion. We should change the name everywhere at once. |
Updating documentation to reflect current
master
version.