Skip to content

Conversation

amallia
Copy link
Member

@amallia amallia commented Apr 3, 2020

Added regression experiment for Robust04

Copy link
Member

@elshize elshize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but here's an idea that we've kind of touched on with @JMMackenzie before. How about create a docker image that executes the entire script? You'd have to mount the input directory with the collection, but then all else would just work automatically. This way, we can very quickly run these tests ourselves.

@amallia
Copy link
Member Author

amallia commented Apr 3, 2020

A few comments but here's an idea that we've kind of touched on with @JMMackenzie before. How about create a docker image that executes the entire script? You'd have to mount the input directory with the collection, but then all else would just work automatically. This way, we can very quickly run these tests ourselves.

I am a bit against Docker for this. It is good if we want to automatically keep updated, for example, effectiveness results on several corpuses. I think having a recipe-stile guide is still good in order to document how to use PISA.

Also, docker is not always great if you want to use it in interactive mode.

@elshize
Copy link
Member

elshize commented Apr 3, 2020

I am not against the guide, it's good to have it, for sure. But I think docker image also would be nice.

Copy link
Member

@JMMackenzie JMMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am agnostic on the Docker issue. Could always come back to it if we like?

@elshize
Copy link
Member

elshize commented Apr 6, 2020

Yeah, we can do (or not) docker later, just saying...

@amallia
Copy link
Member Author

amallia commented Jun 11, 2020

@elshize @JMMackenzie I have updated the documentation according to your comments.

@elshize elshize changed the title Added regression experiment Regression experiment documentation Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          90       90           
  Lines        4915     4915           
=======================================
  Hits         4542     4542           
  Misses        373      373           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ed0d6...b397caf. Read the comment docs.

@amallia
Copy link
Member Author

amallia commented Jun 11, 2020

@elshize addressed comments

@elshize
Copy link
Member

elshize commented Jun 11, 2020

@amallia I added more formatting fixes, take a look if okay.

@amallia amallia merged commit daeeab9 into master Jun 11, 2020
@elshize elshize deleted the regression_robust04 branch June 11, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants