-
-
Notifications
You must be signed in to change notification settings - Fork 71
Regression experiment documentation #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but here's an idea that we've kind of touched on with @JMMackenzie before. How about create a docker image that executes the entire script? You'd have to mount the input directory with the collection, but then all else would just work automatically. This way, we can very quickly run these tests ourselves.
I am a bit against Docker for this. It is good if we want to automatically keep updated, for example, effectiveness results on several corpuses. I think having a recipe-stile guide is still good in order to document how to use PISA. Also, docker is not always great if you want to use it in interactive mode. |
I am not against the guide, it's good to have it, for sure. But I think docker image also would be nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am agnostic on the Docker issue. Could always come back to it if we like?
Yeah, we can do (or not) docker later, just saying... |
@elshize @JMMackenzie I have updated the documentation according to your comments. |
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 90 90
Lines 4915 4915
=======================================
Hits 4542 4542
Misses 373 373 Continue to review full report at Codecov.
|
@elshize addressed comments |
@amallia I added more formatting fixes, take a look if okay. |
Added regression experiment for Robust04