Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update treestyletab.dtd #595

Merged
merged 1 commit into from
Nov 9, 2013
Merged

Update treestyletab.dtd #595

merged 1 commit into from
Nov 9, 2013

Conversation

AxlMun
Copy link
Contributor

@AxlMun AxlMun commented Nov 9, 2013

Add some french translations in the "New Tab" and "Autohide" dialog boxes. This solves issue #594.

Add some french translations
piroor added a commit that referenced this pull request Nov 9, 2013
Update French translation (by AxlMun)
@piroor piroor merged commit 691e4a6 into piroor:master Nov 9, 2013
@piroor
Copy link
Owner

piroor commented Nov 9, 2013

Thanks a lot!!

@AxlMun
Copy link
Contributor Author

AxlMun commented Nov 9, 2013

If I understand the work with GitHub I can delete my branch now.
Isn't it ?

@piroor
Copy link
Owner

piroor commented Nov 9, 2013

Yes, you can delete your repository. But you can update the translation easily if you keep it there - you'll only have to merge my changes to your copy, update translations, and send a pull request again.

@muescha
Copy link

muescha commented Nov 9, 2013

there is no easy way at Github to merge changes to the own repo ( https://help.github.com/articles/syncing-a-fork ).

PS: sometimes its more easy to delete your branch and your copy and make a new fork.

@AxlMun
Copy link
Contributor Author

AxlMun commented Nov 10, 2013

Thanks muescha for the reference. This worked fine the first time.
However you're right it's not easy. I'm getting an error the second time ; I try to fix it with GitHub GUI and I'm quite apprehensive of the result (have a look at the graph ont the GitHub site).

@AxlMun
Copy link
Contributor Author

AxlMun commented Nov 12, 2013

Hi Piroor,

Next the work on treestyletab.dtd, I would like to achieve the same on
treestyletab.properties.
I did the job except 2 things.

  • 3 sentences which I can't find the corresponding use case. That's a risk
    for the translation accuracy.
  • some texts placed in comment seem to be obsolete or deprecated.

I reported these 2 things in issue #598.
I am ready to complete the job as soon as I have the answers

Regards

2013/11/9 piroor notifications@github.com

Thanks a lot!!


Reply to this email directly or view it on GitHubhttps://github.com//pull/595#issuecomment-28129376
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants