This repository was archived by the owner on Nov 7, 2018. It is now read-only.
Use ENV to add elasticsearch-keystore entries #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pires
approved these changes
Jan 22, 2018
|
Is this ready to be merged? |
|
@jjungnickel I'm having second thoughts about this. |
|
@pires Let's talk about it :-) |
|
Would love to but my day job is sucking a lot of my energy and this is low priority. I am very sorry for that. I'll sleep on this over the weekend. Ping me next week. |
|
Don't worry, we've all been there. We already have this integrated in our private repo and image, just wanted to push this upstream, so there's no actual pressure ;-) |
|
Hello I am interested in this evolution too, since it has been approved can someone solve the conflict and merge this in the repo? |
patricktoelle
force-pushed
the
feature/es-keystore
branch
from
40109c1 to
b0cb571
Compare
|
Just rebased onto master |
|
@yciabaud @jjungnickel can you please try this and let me know? |
|
That's exactly what I did on my repo, will check tomorrow to be sure. |
|
LGTM |
pires
force-pushed
the
master
branch
3 times, most recently
from
738723d to
e14ad80
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.