Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4021 - Move Servlet TCK into the Piranha Servlet TCK sub directory #4022

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/workflows/tck-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
run: mvn -B -DskipTests=true install
- name: Run TCK
run: mvn -amd -B -P external -pl external/tck/el verify
jakarta-servlet:
jakarta-pages:
runs-on: ${{ matrix.os }}
strategy:
matrix:
Expand All @@ -36,20 +36,16 @@ jobs:
steps:
- name: Checkout sources
uses: actions/checkout@v4
- name: Setup Java
- name: Set up Java ${{ matrix.java }}
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: ${{ matrix.java }}
- name: Setup for TCK
run: mvn -B -DskipTests=true install -P${{ github.event.inputs.httpImplementation }}
if: ${{ github.event.inputs.httpImplementation }}
- name: Setup for TCK
run: mvn -B -DskipTests=true install
if: ${{ !github.event.inputs.httpImplementation }}
- name: Run TCK
run: mvn -amd -B -P external -pl external/tck/servlet verify
jakarta-pages:
run: mvn -amd -B -P external -pl external/tck/wasp verify
servlet:
runs-on: ${{ matrix.os }}
strategy:
matrix:
Expand All @@ -63,7 +59,13 @@ jobs:
with:
distribution: 'temurin'
java-version: ${{ matrix.java }}
- name: Setup for TCK
run: mvn -B -DskipTests=true install -P${{ github.event.inputs.httpImplementation }}
if: ${{ github.event.inputs.httpImplementation }}
- name: Setup for TCK
run: mvn -B -DskipTests=true install
if: ${{ !github.event.inputs.httpImplementation }}
- name: Run TCK
run: mvn -amd -B -P external -pl external/tck/wasp verify
run: |
mvn -amd -B -P external -pl external/tck/server/servlet verify
cat external/tck/server/servlet/target/piranha/report/text/summary.txt >> $GITHUB_STEP_SUMMARY
26 changes: 26 additions & 0 deletions external/tck/server/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>

<project
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns:if="ant:if">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>cloud.piranha.external.tck</groupId>
<artifactId>project</artifactId>
<version>24.9.0-SNAPSHOT</version>
</parent>
<groupId>cloud.piranha.external.tck.server</groupId>
<artifactId>project</artifactId>
<packaging>pom</packaging>
<name>Piranha - External - TCK - Server - Project</name>
<properties>
<!-- TCK versions -->
<servlet.tck.version>6.0.1</servlet.tck.version>
<!-- Implementation versions -->
</properties>
<modules>
<module>servlet</module>
</modules>
</project>
307 changes: 307 additions & 0 deletions external/tck/server/servlet/pom.xml

Large diffs are not rendered by default.

704 changes: 0 additions & 704 deletions external/tck/servlet/pom.xml

This file was deleted.

Loading