perf: improve n-quad parser using map-based lookups #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the O(n) per-triple equality check with an O(1) map-based set for each graph, improving parsing performance for large (>1000) datasets. To make Quad hashable, all structs implementing the Node interface are now value-based (e.g., IRI implements the Node interface instead of *IRI). Signed-off-by: Michael Adler <michael.adler@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the O(n) per-triple equality check with an O(1) map-based set for each graph, improving parsing performance for large datasets (>1000 entries).
To make
Quadhashable, all structs implementing theNodeinterface are now value-based (e.g.,IRIimplements theNodeinterface instead of*IRI).Note: The
Equalmethod from theNodeinterface is now unused and could be removed. However, I've kept it to maintain compatibility with existing downstream code.Basic Example
No change in existing behavior.
Motivation
The motivation is (yet again) performance. Benchmark results from my machine show:
Checks
make test