fix: avoid tracing-context AttributeError in service decorators#4566
Open
AlessioSpallino wants to merge 2 commits into
Open
fix: avoid tracing-context AttributeError in service decorators#4566AlessioSpallino wants to merge 2 commits into
AlessioSpallino wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a tracing-related crash in service decorators during function-call handling.
Problem
In some function-call paths, tracing context access could raise:
'NoneType' object has no attribute 'get_turn_context'This can happen when
_tracing_contextis truthy at the call-site check, but the underlying getter path raises anAttributeError.Root Cause
_get_turn_context() and _get_parent_service_context() used direct getter calls after a truthiness check.
That check does not protect against AttributeError raised inside get_turn_context() / get_conversation_context().
How to reproduce
'NoneType' object has no attribute 'get_turn_context'when tracing context isn’t available.Changes
Updated
_get_turn_contextto return None on AttributeError.Updated
_get_parent_service_contextto return None conversation context on AttributeError, then keep the existing fallback behaviour.Tests
Added targeted regression tests in
tests/test_service_tracing_decorators.py:Validation run:
uv run pytest tests/test_service_tracing_decorators.py