-
Notifications
You must be signed in to change notification settings - Fork 209
Remove setting defaults in the SDK #6168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
khanhtc1202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to let the dev manage how to set values for plugin config 🙆♂️
ffjlabo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6168 +/- ##
=======================================
Coverage 28.56% 28.57%
=======================================
Files 535 535
Lines 57288 57285 -3
=======================================
+ Hits 16364 16367 +3
+ Misses 39652 39647 -5
+ Partials 1272 1271 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I added |
What this PR does:
This PR removes the code setting defaults in the SDK.
Why we need it:
It's clear to implement setting default values in the plugin code.
Which issue(s) this PR fixes:
Part of #5530
Does this PR introduce a user-facing change?: