Skip to content

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Aug 26, 2025

What this PR does:

This PR removes the code setting defaults in the SDK.

Why we need it:

It's clear to implement setting default values in the plugin code.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi requested a review from a team as a code owner August 26, 2025 02:14
@github-actions github-actions bot added area/go area/plugin-sdk piped-plugin-sdk labels Aug 26, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to let the dev manage how to set values ​​for plugin config 🙆‍♂️

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 26, 2025 02:17
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.57%. Comparing base (1a0e3c2) to head (4d787b9).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6168   +/-   ##
=======================================
  Coverage   28.56%   28.57%           
=======================================
  Files         535      535           
  Lines       57288    57285    -3     
=======================================
+ Hits        16364    16367    +3     
+ Misses      39652    39647    -5     
+ Partials     1272     1271    -1     
Flag Coverage Δ
. 23.13% <ø> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.91% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.32% <ø> (+0.07%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202 khanhtc1202 merged commit 1f22063 into master Aug 26, 2025
45 of 48 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-defaults-set-in-sdk branch August 26, 2025 02:19
@t-kikuc
Copy link
Member

t-kikuc commented Aug 26, 2025

I added change-category/notable-change since this PR forces existing plugins to modify handling defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants