Skip to content

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Sep 27, 2024

What this PR does / why we need it:

Mainly:

  • upgraded aws-sdk-go-v2 especially aws-sdk-go-v2/service/ecs

Associated tasks:

Which issue(s) this PR fixes:

Fixes #5144

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.99%. Comparing base (1689c63) to head (64a6065).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/platformprovider/ecs/client.go 0.00% 1 Missing ⚠️
pkg/filestore/s3/s3.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5241      +/-   ##
==========================================
+ Coverage   22.92%   23.99%   +1.07%     
==========================================
  Files         420      438      +18     
  Lines       45336    47050    +1714     
==========================================
+ Hits        10392    11291     +899     
- Misses      34147    34857     +710     
- Partials      797      902     +105     
Flag Coverage Δ
23.99% <88.88%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc
Copy link
Member Author

t-kikuc commented Sep 27, 2024

reopen for rerun snyk test

@t-kikuc
Copy link
Member Author

t-kikuc commented Sep 30, 2024

re:reopen for rerun snyk test

@t-kikuc t-kikuc closed this Sep 30, 2024
@t-kikuc t-kikuc reopened this Sep 30, 2024
@t-kikuc t-kikuc closed this Oct 1, 2024
@t-kikuc t-kikuc reopened this Oct 1, 2024
@t-kikuc t-kikuc marked this pull request as ready for review October 1, 2024 02:24
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit ac9ed87 into master Oct 1, 2024
46 of 47 checks passed
@t-kikuc t-kikuc deleted the upgrade-aws-sdk branch October 1, 2024 04:54
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
* Generate v0.49.x docs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* upgrade aws-sdk-go-v2

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* upgrade aws-sdk-go-v2/**/*

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix compile errors caused by the breaking change

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix a test due to added RestartPolicy

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix: avoid panic when live taskdef does not exist

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix go.sum by `make update/go-deps`

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
t-kikuc added a commit that referenced this pull request Oct 8, 2024
#5263 (#5265)

* Fix panic in ECS driftdetection when a taskdef in livestates does not exist (#5240)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix: avoid panic when live taskdef does not exist

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Upgrade aws-sdk-go-v2 (#5241)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* upgrade aws-sdk-go-v2

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* upgrade aws-sdk-go-v2/**/*

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix compile errors caused by the breaking change

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix a test due to added RestartPolicy

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix: avoid panic when live taskdef does not exist

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix go.sum by `make update/go-deps`

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Remove an unused field 'configFilePathInGitRepo' (#5248)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* remove unused field 'configFilePathInGitRepo'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Support fetching a piped config from AWS SSM Parameter Store (#5249)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* add --aws-ssm-parameter

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* add config-aws-ssm-parameter to piped

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* update docs of runtime options

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Remove subnet ordering in head manifest (#5254)

Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Update quickstart header note (#5255)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Update feature status (#5256)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Support directly designating a gitSSHKey instead of File for launcher (#5258)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* add --git-ssh-key-env

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* update docs: add '--git-ssh-key-env'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* add '\n' at the end of ssh key

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Directly use data instead of env

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Clarify the flag description

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix error message:  'and' -> 'or'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Add workflow steps to build and publish quickstart manifests (#5260)

Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Update workflow not to run by matrix (#5262)

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Update RELEASE to v0.49.1 and update v0.49.x docs (#5263)

* update RELEASE to v0.49.1

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* update docs of v0.49.x by `make release version=v0.49.1`

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Co-authored-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable restart policy property for ECS application
3 participants