Skip to content

Conversation

@KieranP
Copy link

@KieranP KieranP commented Mar 25, 2025

Describe the change

Support using v3 of unicode-display_width

Why are we doing this?

Inline with rubocop requirements, so that we're not forcing users to downgrade

Benefits

Allow users of tty-progressbar to use latest gem versions

Drawbacks

None known

Requirements

  • Tests written & passing locally?
  • Code style checked?
  • Rebased with master branch?
  • Documentation updated?
  • Changelog updated?

Support using v3 of unicode-display_width, inline with rubocop, so that we're not forcing users to downgrade
Copy link
Owner

@piotrmurach piotrmurach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

I'm all for relaxing the constraints on the unicode-display_width gem to allow for newer versions.

In a strict sense, the current constraints don't require any downgrade action on the user unless they are intent on using the very lastest unicode-display_width gem version. Usually, this is a transitory dependency, and most users probably don't use it directly.

I'd also appreciate a change note in the changelog. This can be under ## unreleased and ### Changed headings.

KieranP and others added 2 commits March 27, 2025 16:29
Co-authored-by: Piotr Murach <pmurach@gmail.com>
@KieranP
Copy link
Author

KieranP commented Mar 27, 2025

In a strict sense, the current constraints don't require any downgrade action on the user unless they are intent on using the very lastest unicode-display_width gem version. Usually, this is a transitory dependency, and most users probably don't use it directly.

True, however as a maintainer of an app that handles PII, it's always best to have all dependencies be on the latest version with security/bug fixes. Requiring a downgrade for a dependency in order to install latest versions of something we need is not an ideal compromise.

I'd also appreciate a change note in the changelog. This can be under ## unreleased and ### Changed headings.

Done

Copy link
Owner

@piotrmurach piotrmurach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! The changelog entry needs some editing.

KieranP and others added 2 commits March 31, 2025 09:11
Co-authored-by: Piotr Murach <pmurach@gmail.com>
Co-authored-by: Piotr Murach <pmurach@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants