-
-
Notifications
You must be signed in to change notification settings - Fork 25
Update unicode-display_width dependency #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Support using v3 of unicode-display_width, inline with rubocop, so that we're not forcing users to downgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
I'm all for relaxing the constraints on the unicode-display_width gem to allow for newer versions.
In a strict sense, the current constraints don't require any downgrade action on the user unless they are intent on using the very lastest unicode-display_width gem version. Usually, this is a transitory dependency, and most users probably don't use it directly.
I'd also appreciate a change note in the changelog. This can be under ## unreleased and ### Changed headings.
Co-authored-by: Piotr Murach <pmurach@gmail.com>
True, however as a maintainer of an app that handles PII, it's always best to have all dependencies be on the latest version with security/bug fixes. Requiring a downgrade for a dependency in order to install latest versions of something we need is not an ideal compromise.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! The changelog entry needs some editing.
Co-authored-by: Piotr Murach <pmurach@gmail.com>
Co-authored-by: Piotr Murach <pmurach@gmail.com>
Describe the change
Support using v3 of unicode-display_width
Why are we doing this?
Inline with rubocop requirements, so that we're not forcing users to downgrade
Benefits
Allow users of tty-progressbar to use latest gem versions
Drawbacks
None known
Requirements
masterbranch?