Add Ghostty terminal hyperlink support#3
Conversation
piotrmurach
left a comment
There was a problem hiding this comment.
Hi Akshay,
Thank you for submitting this PR. 🙏
I'm all in favour of adding Ghostty support. I left a couple of comments, though. In particular, I'm curious about the version check. Would you have time to investigate?
33e1270 to
7778e6f
Compare
|
Thanks for the review @piotrmurach ! I have updated the code as per review comments. |
piotrmurach
left a comment
There was a problem hiding this comment.
Thank you for making the changes. We are nearly there.
5f9fbed to
f7ab9bb
Compare
|
Friendly bump for review. |
piotrmurach
left a comment
There was a problem hiding this comment.
@the-spectator Sorry for the delay in my review.
I went through all the changes. Most comments relate to tests to ensure consistency in formatting and ordering. I included an extra test to match the other terminal tests.
Once this is merged, I plan to make a couple more changes to link rendering before making a new release.
f7ab9bb to
5337e2f
Compare
|
Thanks for the review @piotrmurach ! I have addressed the review comments. |
piotrmurach
left a comment
There was a problem hiding this comment.
Thank you for making the changes. I noticed some small test improvements.
65693f4 to
9a26b95
Compare
9a26b95 to
a533ad3
Compare
|
@the-spectator Sorry to keep you waiting so long for a review. I appreciate your patience. I plan to resume making updates soon. Please do not rebase until further notice. I may backtrack on some of the changes. Once done, I will let you know so we can merge this PR. |
|
Noted. 👍 |
Closes #2
Describe the change
Add Ghostty terminal hyperlink support
Why are we doing this?
To extend the supported terminal list.
Requirements
masterbranch?