Add rounded corners #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piotrmurach Please merge this PR! The rounded corners rock and they add a much needed class to the boxes :)
|
|
@ameuret Thank you for adding rounded corners :) |
|
@piotrmurach Please merge this! It's really nice to have rounded corners on boxes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
It adds a rounded corners border type.
Why are we doing this?
Because everyone loves rounded corners.
Benefits
It will bring more joy to the users.
Drawbacks
None. I checked that the rounded corners ╯ ╮ ╭ ╰ don't exhibit the incorrect width issues that many Unicode characters (such as Emojis) trigger in most terminal emulators.
Requirements
masterbranch?