Irregular plural words: plural? and plural both fail (people => peoples)

[DannyBen]

Of course you also have a gem for string inflection...

You are my one stop shop for "gem supplies" 🛒

Problem

Strings::Inflection.plural? on irregular plurals fails.

Reproduction

require 'strings-inflection'
require 'strings/inflection/extensions'
using Strings::Inflection::Extensions

# These fail
p 'people'.pluralize == 'people' # => false
p 'people'.plural? == true       # => false
p 'children'.plural? == true     # => false

# These are all ok, just here as a "full test suite"
p 'person'.singular? == true    
p 'child'.singular? == true     
p 'people'.singular? == false   
p 'children'.singular? == false 
p 'person'.plural? == false     
p 'child'.plural? == false

Additional information

The underlying root cause of this problem, is that the gem returns "peoples" as the plural form of people, which is wrong. In ActiveSupport Inflector, it is returned properly:

>> require 'active_support/inflector'
=> true
>> "people".singularize
=> "person"
>> "people".pluralize
=> "people"

[piotrmurach]

Thanks for reporting this! This gem is part of the strings family that I'm trying to put together. It's relatively young so still has some rough edges and growing to do 😉

Do you have time to look into this? There are regexes for irregular nouns that need tweaking. Or a better method to detect singular vs plural. Any help appreciated.

[DannyBen]

I will take a look.

[DannyBen]

Well - I found the problem, I have no idea how to untangle it.

1. The #plural? method compares the word to its plural form:

strings-inflection/lib/strings/inflection/term.rb

Lines 64 to 68 in b51b34d

	def plural?
	return false if word.to_s.empty?
	word.downcase == plural
	end

2. The #plural of people is currently returned as peoples, which is not equal to the input word people.

3. The Noun#plural method, uses Nouns#plurals - the condition below returns peoples when hitting find_match(Nouns.plurals)

strings-inflection/lib/strings/inflection/noun.rb

Lines 50 to 55 in b51b34d

	def plural
	return word if word.to_s.empty?
	find_match(Inflection.configuration.plurals[:noun]) ||
	(uncountable? && word) || find_match(Nouns.plurals) || word
	end

4. This is due to the "catch all" rule in the @plural_rules, which just adds s to everything.

strings-inflection/lib/strings/inflection/nouns.rb

Line 679 in b51b34d

[/\A(.+)$/i, "\\1s"]

[walterdavis]

I think that this inflector is being more general here, thinking of it as in "the Inuit people" versus "the indigenous peoples of the Arctic region". I admit that's quite a stretch. Perhaps you need to add an inflector rule for that word. Perhaps ActiveSupport already does this and we're not used to seeing the need. Walter

…

On May 15, 2020, at 12:25 PM, Danny Ben Shitrit ***@***.***> wrote: Well - I found the problem, I have no idea how to untangle it. • The #plural? method compares the word to its plural form: https://github.com/piotrmurach/strings-inflection/blob/b51b34d1a49853653303725122fbcc0f3ede9233/lib/strings/inflection/term.rb#L64-L68 • The #plural of people is currently returned as peoples, which is not equal to the input word people. • The Noun#plural method, uses Nouns#plurals - the condition below returns peoples when hitting find_match(Nouns.plurals) https://github.com/piotrmurach/strings-inflection/blob/b51b34d1a49853653303725122fbcc0f3ede9233/lib/strings/inflection/noun.rb#L50-L55 • This is due to the "catch all" rule in the @plural_rules, which just adds s to everything. https://github.com/piotrmurach/strings-inflection/blob/b51b34d1a49853653303725122fbcc0f3ede9233/lib/strings/inflection/nouns.rb#L679 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[DannyBen]

The root cause of this issue is that the gem does not properly handle pluralization of already pluralized irregular words. I have updated the issue description with more info.

[piotrmurach]

Thanks, @DannyBen for investigating. I think the root cause is not necessarily pluralization of plural words, but more precise, pluralization of irregular plural words.

Strings::Inflection.pluralize("words") # => "words"
Strings::Inflection.pluralize("mice") # => "mices"

As far as I can see the solution is to add irregular plurals that are already plural to the list:

[/people\z/, "people"]

@walterdavis It's not that sophisticated 😄 Though it's already much more powerful that ActiveSupport, it handles plenty irregular forms:

Strings::Inflection.pluralize("goose") # => "geese"
ActiveSupport::Inflector.pluralize("goose") #=> "gooses"

[piotrmurach]

Sorry for closing - pressed mouse somehow with a pointer on 'close and comment'...